Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leaks #895

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Fixed memory leaks #895

merged 6 commits into from
Aug 8, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Jul 13, 2024

Description

Fixed memory leaks. The following was done:

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

- Fixed leak in json_memload()
- Fixed leak in global session when running with DLITE_ATEXIT_FREE set
- Added a FIXME for a leak in mapping_create_rec() in src/dlite-mappings.c
- Set DLITE_ATEXIT_FREE when running `make memcheck`
- Ignore external leaks in pydantic and numpy random_bit_generator
src/dlite-mapping.c Outdated Show resolved Hide resolved
src/dlite-mapping.c Outdated Show resolved Hide resolved
src/dlite-misc.c Outdated Show resolved Hide resolved
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
# For Pydantic

{
<insert_a_suppression_name_here>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert a suppression name here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment and moved suppression to valgrind-python.supp.

jesper-friis and others added 2 commits August 6, 2024 14:06
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when comments have been adressed

@jesper-friis jesper-friis merged commit ff1047f into master Aug 8, 2024
15 checks passed
@jesper-friis jesper-friis deleted the fix-memory-leaks branch August 8, 2024 07:57
@jesper-friis jesper-friis restored the fix-memory-leaks branch November 16, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants